resharding: cleanup #585
Merged
resharding: cleanup #585
+76
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Jan 30, 2025
neps/nep-0568.md
Outdated
Comment on lines
117
to
118
| Since [Stateless Validation][NEP-508], all shards tracking is no longer required. Currently, shard cleanup has not been implemented. We propose a cleanup mechanism that will also handle post-resharding cleanup. | ||
|
|
There was a problem hiding this comment.
Can you define briefly what is state cleanup and under what circumstances it is needed?
neps/nep-0568.md
Outdated
|
|
||
| Since [Stateless Validation][NEP-508], all shards tracking is no longer required. Currently, shard cleanup has not been implemented. We propose a cleanup mechanism that will also handle post-resharding cleanup. | ||
|
|
||
| When garbage collection removes the last block of an epoch from the canonical chain, we determine which shards were tracked during that epoch by examining the shards present in `TrieChanges` at that block. Similarly, we collect information on shards tracked in subsequent epochs, up to the present one. A shard State is removed only if: |
There was a problem hiding this comment.
nit: two spaces between "collect" and "information"
neps/nep-0568.md
Outdated
|
|
||
| #### Negative refcounts | ||
|
|
||
| Some trie keys (e.g. `TrieKey::DelayedReceipt`) are shared among child shards, but their corresponding State is not duplicated. The `DBCol::State` column uses reference counting, meaning some data is counted only once, despite being referenced by multiple child shards. This can result in negative refcounts when the data is later removed. To mitigate this, we modify the RocksDB `refcount_merge` behavior so that negative refcounts are clamped to 0. |
There was a problem hiding this comment.
Can you mention that this is sub-optimal, why, and that we should follow up?
Trisfald
approved these changes
Jan 30, 2025
neps/nep-0568.md
Outdated
| @@ -112,6 +112,22 @@ Cold storage uses the same mapping strategy to manage shard state during reshard | |||
|
|
|||
| This approach minimizes complexity while maintaining consistency across hot and cold storage. | |||
|
|
|||
| #### State cleanup | |||
|
|
|||
| Since [Stateless Validation][NEP-508], all shards tracking is no longer required. Currently, shard cleanup (e.g. when we stopped tracking one shard and started tracking another shard) has not been implemented. With resharding, we would also want to cleanup parent shard once we stop tracking all its descendants. We propose a shard cleanup mechanism that will also handle post-resharding cleanup. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.